Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove overlays, are identical for node & browser #2005

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove overlays, are identical for node & browser #2005

wants to merge 1 commit into from

Conversation

cdebost
Copy link
Collaborator

@cdebost cdebost commented Jan 22, 2019

Related to montagejs/mr#141. Overlay seems to be serving no purpose in this repository.

@hthetiot
Copy link
Contributor

hthetiot commented Jan 29, 2019 •
edited
Loading

+1 if master already ready

@hthetiot hthetiot requested a review from tejaede January 29, 2019 01:40
@hthetiot
Copy link
Contributor

Does #1990 use overlay ?

@cdebost
Copy link
Collaborator Author

cdebost commented Jan 30, 2019

@hthetiot Different kind of overlay. That PR is for the UI overlay component. In this PR, overlay refers to the extra package.json property that we use to resolve dependencies differently on browser vs node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejaede tejaede Awaiting requested review from tejaede

Assignees

@cdebost cdebost

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdebost @hthetiot